[pve-devel] Disks hotplug patchs

[Dietmar Maurer]

just commited your patches (available in a few minutes) - please pull changes/cleanups

> -----Original Message-----
> From: Alexandre DERUMIER [mailto:aderumier at odiso.com]
> Sent: Dienstag, 11. Oktober 2011 13:19
> To: Dietmar Maurer
> Cc: pve-devel at pve.proxmox.com
> Subject: Re: [pve-devel] Disks hotplug patchs
> 
> I think I can do better, i'm reading libvirt code and  "drive_del" return error code
> if something goes wrong guest side.
> 
> I'll add a check.
> 
> 
> ----- Mail original -----
> 
> De: "Alexandre DERUMIER" <aderumier at odiso.com>
> À: "Dietmar Maurer" <dietmar at proxmox.com>
> Cc: pve-devel at pve.proxmox.com
> Envoyé: Mardi 11 Octobre 2011 12:40:08
> Objet: Re: [pve-devel] Disks hotplug patchs
> 
> 
> If you try to unplug a disk in use , mounted by exemple , the unplug will fail.
> 
> Device is not remove, that's why I parse the "info pci" output.
> 
> I the device is always present after the unplug , I sent a die "error on hot-
> unplugging device" .
> 
> 
> 
> 
> ----- Mail original -----
> 
> De: "Dietmar Maurer" <dietmar at proxmox.com>
> À: "Derumier Alexandre" <aderumier at odiso.com>, pve-
> devel at pve.proxmox.com
> Envoyé: Mardi 11 Octobre 2011 06:35:35
> Objet: RE: [pve-devel] Disks hotplug patchs
> 
> > - 2 hook to call vm_deviceadd/vm_devicedel, when config file is updated
> 
> What happens when we hot-unplug a disk device? If the disk is still in use by the
> VM?
> Does that crash the linux kernel?
> 
> - Dietmar
> 
> 
> 
> 
> --
> 
> 
> 
> 
> 
> 	Alexandre Derumier
> Ingénieur système
> e-mail : aderumier at odiso.com
> Tél : +33 (0)3 20 68 88 90
> Fax : +33 (0)3 20 68 90 81
> 45 Bvd du Général Leclerc
> 59100 ROUBAIX - FRANCE
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> --
> 
> --
> 
> 
> 
> 
> 
> 	Alexandre Derumier
> Ingénieur système
> e-mail : aderumier at odiso.com
> Tél : +33 (0)3 20 68 88 90
> Fax : +33 (0)3 20 68 90 81
> 45 Bvd du Général Leclerc
> 59100 ROUBAIX - FRANCE
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
>