[pve-devel] [PATCH 5/6] add a hook to call vm_deviceadd when the disk in config file are added

[Alexandre DERUMIER]

yes,I had think about this problem. 
with pve-manager, you can add only 1 device at one time, si no problem 
but with qm command we can add as many device at once. 


Maybe the best and cleanest thing is to add new qm commands, 


like "qm deviceadd xxx" "qm devicedel xxx". 




but this need more work and changes in pve-manager (and I'm pretty bad with extjs ;) 


Maybe do you have another idea/solution ....? 



----- Mail original -----

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Derumier Alexandre" <aderumier at odiso.com>, pve-devel at pve.proxmox.com 
Envoyé: Lundi 10 Octobre 2011 19:59:17 
Objet: RE: [pve-devel] [PATCH 5/6] add a hook to call vm_deviceadd when the disk in config file are added 

what if you add several hotplug disks at one, and one action fails? 

> -----Original Message----- 
> From: pve-devel-bounces at pve.proxmox.com [mailto:pve-devel- 
> bounces at pve.proxmox.com] On Behalf Of Derumier Alexandre 
> Sent: Montag, 10. Oktober 2011 16:47 
> To: pve-devel at pve.proxmox.com 
> Subject: [pve-devel] [PATCH 5/6] add a hook to call vm_deviceadd when the disk 
> in config file are added 
> 
> 
> Signed-off-by: Derumier Alexandre <aderumier at odiso.com> 
> --- 
> PVE/QemuServer.pm | 1 + 
> 1 files changed, 1 insertions(+), 0 deletions(-) 
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 80ab7c7..70e3979 
> 100644 
> --- a/PVE/QemuServer.pm 
> +++ b/PVE/QemuServer.pm 
> @@ -1302,6 +1302,7 @@ sub create_disks { 
> die "image '$path' does not exists\n"; 
> } 
> } 
> + PVE::QemuServer::vm_deviceadd ($storecfg,$vmid,$ds, $disk); 
> }); 
> }; 
> 
> -- 
> 1.7.2.5 
> 
> _______________________________________________ 
> pve-devel mailing list 
> pve-devel at pve.proxmox.com 
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 





-- 




	
	Alexandre Derumier 
Ingénieur système 
e-mail : aderumier at odiso.com 
Tél : +33 (0)3 20 68 88 90 
Fax : +33 (0)3 20 68 90 81 
45 Bvd du Général Leclerc 
59100 ROUBAIX - FRANCE 













-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20111010/120a7c2e/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: aderumier.vcf
Type: text/x-vcard
Size: 183 bytes
Desc: not available
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20111010/120a7c2e/attachment.vcf>