[pve-devel] r4885 - pve-access-control/trunk

[svn-commits at proxmox.com]

Author: dietmar
Date: 2010-07-09 04:39:10 +0000 (Fri, 09 Jul 2010)
New Revision: 4885

Modified:
   pve-access-control/trunk/AccessControl.pm
   pve-access-control/trunk/ChangeLog
Log:
* AccessControl.pm (modify_acl): check if role exists



Modified: pve-access-control/trunk/AccessControl.pm
===================================================================
--- pve-access-control/trunk/AccessControl.pm	2010-07-08 07:28:57 UTC (rev 4884)
+++ pve-access-control/trunk/AccessControl.pm	2010-07-09 04:39:10 UTC (rev 4885)
@@ -760,7 +760,7 @@
 	my $propagate = $opts->{propagate} ? 1 : 0;
 	if (my $path = normalize_path($pathtxt)) {
 	    foreach my $role (split_list($rolelist)) {
-		if (!verify_rolename($role, 1)) {
+		if ((!verify_rolename($role, 1)) || (!$cfg->{roles}->{$role})) {
 		    warn "user config - ignore invalid role name '$role' in acl\n";
 		    next;
 		}

Modified: pve-access-control/trunk/ChangeLog
===================================================================
--- pve-access-control/trunk/ChangeLog	2010-07-08 07:28:57 UTC (rev 4884)
+++ pve-access-control/trunk/ChangeLog	2010-07-09 04:39:10 UTC (rev 4885)
@@ -1,3 +1,7 @@
+2010-07-09  Seth Lauzon <seth.lauzon at gmail.com>
+
+	* AccessControl.pm (modify_acl): check if role exists
+
 2010-07-08  Proxmox Support Team  <support at proxmox.com>
 
 	* pveum (print_usage): improve usage text.