[pmg-devel] [PATCH pmg-api/pmg-gui v3 0/2] fix #3450: batch deletion/delivery for postfix queue

[Maximiliano Sandoval]

Hannes Laimer <h.laimer at proxmox.com> writes:

> Adds a new POST endpoint that accepts both a type(delete/deliver) and a
> list of id's. This is also how batch operations are done for quarantine.
>
> https://bugzilla.proxmox.com/show_bug.cgi?id=3450
>
> v3, thanks @Thomas:
>  - code cleanup
>  - add more context to commit messages
>  - remove not needed checks when passing a list of ids to `postsuper -d -`
>  - ui: use INFO instead of WARNING confirm popup, same as we do for quarantine
>  - ui: no confirmation for flush of single mails, so existing behaviour of the
>    button does not change
>
> v2:
>  - instead of 'filter' use the IDs directly
>  - UI now doesn't have extra buttons, the existing Remove and Flush ones
>    will just work with either one or multiple selected items

I tested the changes and the UX is as expected. Only issue I had is that
the checkbox is too small to click manually when not using the filter,
but that seems to be out-of-scope for the current series.

The changes to pmg-api look OK to me. It is a bit unfortunate to
potentially loop over a big number of `postqueue -i` calls in
flush_queue_ids but from reading their man page I don't think they offer
a better alternative.

Tested-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
-- 
Maximiliano