[pmg-devel] applied: [PATCH pmg-api v2] fix #5438: api: mimetypes: allow admin users

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Sep 23 11:39:57 CEST 2025


On Tue, 23 Sep 2025 11:26:11 +0200, Stoiko Ivanov wrote:
> The list of mime-types recognized by the system is not really
> sensitive information. The call itself reads a directory from disk,
> which technically has a potential for causing load (but that should be
> cached after the first read).
> 
> Allowing it for all authenticated backend users should be ok.
> 
> [...]

Applied, thanks!

Reworded the commit message a bit to avoid a few redundant mentionings of
allowing it only for admins and the "Allowing it for all authenticated backend
users should be ok." was IMO slightly confusing, as it sorta implied to me that
this is the route you go, while then again mentioning admin-only in the next
paragraph. Anyhow, certainly somewhat nitpicking but tried to avoid that tiny
confusion potential.

[1/1] fix #5438: api: mimetypes: allow admin users
      commit: da0e939b2c7913f90413f928ccc1eaa9c3bb70bd




More information about the pmg-devel mailing list