[pmg-devel] partially-applied: [PATCH-SERIES pmg-api 0/3] fix #2077: remove dependency on Term::ReadLine
Stoiko Ivanov
s.ivanov at proxmox.com
Mon Sep 22 21:11:40 CEST 2025
Thomas applied the pve-common patch - so I went ahead and applied
1/2: e214e9bf ("partially fix #2077: pmgconfig: remove dependency on
Term::ReadLine")
and
2/2: 3f2ccb1f ("partially fix #2077: pmgcm: remove dependency on
Term::ReadLine")
Thanks again for the patches!
On Thu, 18 Sep 2025 16:19:40 +0200
Fiona Ebner <f.ebner at proxmox.com> wrote:
> As a side-effect, this also fixes #6748.
>
> Term::ReadLine would prompt and read from terminal even if
> stdin/stdout are redirected, the new helper will use the redirected
> channels. It also would underline the prompt, which the new helper
> does not. And Term::ReadLine also has advanced editing and history
> shortcuts.
>
> For the prompts in pmgconfig and pmgcm, not having the advanced
> features is perfectly fine. For pmgsh, which additionally configures
> even more features of than mentioned above, the change is rather bad.
>
> Depends on the following pve-common patch:
> https://lore.proxmox.com/pve-devel/20250918135215.95188-2-f.ebner@proxmox.com/
> Dependency bump for pve-common needed.
>
>
> Fiona Ebner (4):
> partially fix #2077: pmgconfig: remove dependency on Term::ReadLine
> partially fix #2077: pmgcm: remove dependency on Term::ReadLine
> partially fix #2077: pmgsh: remove dependency on Term::ReadLine
> d/control: remove libterm-readline-gnu-perl dependency
>
> debian/control | 1 -
> src/PMG/CLI/pmgcm.pm | 7 ++-----
> src/PMG/CLI/pmgconfig.pm | 19 +++++++------------
> src/bin/pmgsh | 35 ++---------------------------------
> 4 files changed, 11 insertions(+), 51 deletions(-)
>
More information about the pmg-devel
mailing list