[pmg-devel] [PATCH pmg-api 2/4] partially fix #2077: pmgcm: remove dependency on Term::ReadLine
Stoiko Ivanov
s.ivanov at proxmox.com
Mon Sep 22 11:46:59 CEST 2025
Tested this by creating a cluster on a trixie based container, and joining
it to my bookworm PMG (the trixie container had pve-common
containing:
https://lore.proxmox.com/pve-devel/20250918135215.95188-2-f.ebner@proxmox.com/
and this patch applied)
Consider this:
Reviewed-by: Stoiko Ivanov <s.ivanov at proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov at proxmox.com>
On Thu, 18 Sep 2025 16:19:42 +0200
Fiona Ebner <f.ebner at proxmox.com> wrote:
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
> src/PMG/CLI/pmgcm.pm | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/src/PMG/CLI/pmgcm.pm b/src/PMG/CLI/pmgcm.pm
> index ab9fe2a..401f680 100644
> --- a/src/PMG/CLI/pmgcm.pm
> +++ b/src/PMG/CLI/pmgcm.pm
> @@ -3,7 +3,6 @@ package PMG::CLI::pmgcm;
> use strict;
> use warnings;
> use Data::Dumper;
> -use Term::ReadLine;
> use POSIX qw(strftime);
> use JSON;
>
> @@ -11,6 +10,7 @@ use PVE::SafeSyslog;
> use PVE::Tools qw(extract_param);
> use PVE::INotify;
> use PVE::CLIHandler;
> +use PVE::PTY;
>
> use PMG::Utils;
> use PMG::Ticket;
> @@ -188,10 +188,7 @@ __PACKAGE__->register_method({
>
> die "cluster already defined\n" if scalar(keys %{ $cinfo->{ids} });
>
> - my $term = new Term::ReadLine('pmgcm');
> - my $attribs = $term->Attribs;
> - $attribs->{redisplay_function} = $attribs->{shadow_redisplay};
> - my $password = $term->readline('Enter password: ');
> + my $password = PVE::PTY::read_password('Enter password: ');
>
> my $setup = {
> username => 'root at pam',
More information about the pmg-devel
mailing list