[pmg-devel] applied: [RFC pmg-api] pmgtunnel: do not set SIGCHLD handler

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Sep 17 12:33:10 CEST 2025


On Mon, 18 Aug 2025 20:07:14 +0200, Stoiko Ivanov wrote:
> Drop the SIGCHLD handling in pmgtunnel, as it's not necessary and
> parts deeper in our code-base (e.g. PVE::Tools::run_command) rely on
> signals not being handled by the callers.
> 
> In the case of pmgtunnel the signalhander (finish_children) simply
> wait(2)'s for all children (no matter if it's a ssh-tunnel process, or
> e.g. `ip link` being called to get network information), and clears
> the ssh-forwarded postgres socket, schedules a (delayed) restart, and
> logs an exit message for the ssh-tunnels.
> 
> [...]

Applied, thanks!

[1/1] pmgtunnel: do not set SIGCHLD handler
      commit: 415933fbb847587188169fe7c7b7b86feddc47a9




More information about the pmg-devel mailing list