[pmg-devel] applied: [PATCH proxmox 1/1] login: fix userid check for '@quarantine' user tickets
Thomas Lamprecht
t.lamprecht at proxmox.com
Tue Oct 21 20:33:12 CEST 2025
On Wed, 15 Oct 2025 16:22:58 +0200, Dominik Csapak wrote:
> when logging into the pmg quarantine via LDAP, the user typically
> enters a userid like 'foo at bar.com'. When receiving a valid ticket,
> this contains a userid like 'foo at bar.com@quarantine'. To check if that's
> correct, use our helper instead of manually checking for equality.
>
> That helper also needs fixing: while it should be (optionally) possible
> to enter the username with 'foo at bar.com@quarantine' (so we have to strip
> the quarantine part from the expected userid), we also have to strip the
> '@quarantine' part from the ticket response, since it contains that too.
>
> [...]
Applied, with some actual unit tests added as follow-up as rust makes doing
that so easy that it's hard to argue for not having them, thanks!
[1/1] login: fix userid check for '@quarantine' user tickets
commit: 7e23aa421fa5d7177fd2ff58d6d217ab6e7c8d80
More information about the pmg-devel
mailing list