[pmg-devel] applied: [PATCH pmg-api v2] utils: verify_username: allow quarantine logins again

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Feb 27 11:12:31 CET 2025


Am 27.02.25 um 10:53 schrieb Stoiko Ivanov:
> verify_username is used in many places to split into realms (the part
> after the last '@') and usernames (everthing before).
> 
> The commit disallowing '@' in usernames broke quarantine login
> (users login with `localpart at domainname.com@quarantine`)
> 
> Fixes: 9665bbc ("utils: user schema: explicitly forbid @ in user-names")
> Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
> ---
> v2: drop double `;` in the PMG::API2::Users patch
>  src/PMG/API2/Users.pm | 2 ++
>  src/PMG/Utils.pm      | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
>

applied, thanks!

In the long run it might be nice to fully allow @ here, but as other places
in the code base do not expect that currently disallowing it here explicitly
is OK I think.




More information about the pmg-devel mailing list