[pmg-devel] [PATCH pmg-api v2 0/2] change sample-entries in default Who-Objects and check in pmg7to8

[Stoiko Ivanov]

On Fri, 21 Feb 2025 09:46:00 +0100
Dominik Csapak <d.csapak at proxmox.com> wrote:

> works as intended, but i just have a question:
> 
> do we usually update the pmg/pve XtoY script that long beforehand?
> because this will now trigger if people now do a 7to8 upgrade
> and call it after the upgrade step then
In this case I'd say it's ok - the issue here is the "wrong" example
addresses - so if someone migrating from 7 or even without runs this and
is notified they can take action in any case. by adding it now we make
sure it will remain in place when we base pmg8to9 on pmg7to8.


> 
> (i believe this is intended for the 8to9 script ?)
> 
> if that's a non-issue, consider this
> 
> Reviewed-by: Dominik Csapak <d.csapak at proxmox.com>
> Tested-by: Dominik Csapak <d.csapak at proxmox.com>
>