[pmg-devel] [PATCH pmg-gui 1/2] rules/object: remove icon from remove button
Stoiko Ivanov
s.ivanov at proxmox.com
Wed Feb 12 16:12:40 CET 2025
the icons were introduced to the listing, and it seems their rendering
when removing was not noticed - w/o this the message is e.g.:
"Are you sure you want to remove entry
'<span class="fa-fw fa fa-file-image-o'"></span> Content Type Filter:
..."
Fixes: ea4f2a7 ("add icons to the object types")
Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
---
js/ObjectGroup.js | 3 +--
js/Utils.js | 5 +++++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/js/ObjectGroup.js b/js/ObjectGroup.js
index 3c8de64..1807e97 100644
--- a/js/ObjectGroup.js
+++ b/js/ObjectGroup.js
@@ -125,8 +125,7 @@ Ext.define('PMG.ObjectGroup', {
},
callback: reload,
getRecordName: function(rec) {
- return PMG.Utils.format_otype(rec.data.otype) +
- ': ' + rec.data.descr;
+ return PMG.Utils.format_otype_subject(rec.data.otype) + ': ' + rec.data.descr;
},
waitMsgTarget: me,
});
diff --git a/js/Utils.js b/js/Utils.js
index 9b5f054..94e3c95 100644
--- a/js/Utils.js
+++ b/js/Utils.js
@@ -128,6 +128,11 @@ Ext.define('PMG.Utils', {
return icon + text;
},
+ format_otype_subject: function(otype) {
+ let editor = PMG.Utils.object_editors[otype];
+ return editor.subject ?? 'unknown';
+ },
+
format_otype: function(otype) {
let editor = PMG.Utils.object_editors[otype];
let iconCls = 'fa fa-question-circle';
--
2.39.5
More information about the pmg-devel
mailing list