[pmg-devel] [PATCH pmg-api/pmg-gui] add information source attribute to content-type what-object
Stoiko Ivanov
s.ivanov at proxmox.com
Wed Feb 12 16:12:37 CET 2025
The following patch series was started shortly after the release of PMG 8.1,
but I did not find the time to get it in shape for sending.
They follow the patches for adding 'top' and 'add_separator' to the
Disclaimer action.
The current content-type filter can sometimes surprise users (e.g.
https://bugzilla.proxmox.com/show_bug.cgi?id=5618#c2 and
https://bugzilla.proxmox.com/show_bug.cgi?id=2691#c0 ,but also a few
cases in our technical support-channels come up here and there):
It matches if any of:
* content-type header
* file-magic
* filename (extension)
match the content type, the what-object matches.
by adding an attribute for each of the sources users can restrict which
of the sources should be taken into consideration
the first patches for both repositories are independent (I just ran into
them while looking into this).
minimally tested locally, by sending a plain-text file called
testtext.pdf, and a pdf-file renamed to have a `.docx` suffix.
pmg-api:
Stoiko Ivanov (2):
ruledb: disclaimer: simplify update-case
ruledb: content-type: add flags for source of matching
src/PMG/RuleDB/ContentTypeFilter.pm | 91 +++++++++++++++++++++++++++--
src/PMG/RuleDB/Disclaimer.pm | 8 +--
2 files changed, 89 insertions(+), 10 deletions(-)
pmg-gui:
Stoiko Ivanov (2):
rules/object: remove icon from remove button
rules/content-typefilter: add match source checkboxes
js/ObjectGroup.js | 3 +--
js/Utils.js | 26 ++++++++++++++++++++++++++
2 files changed, 27 insertions(+), 2 deletions(-)
--
2.39.5
More information about the pmg-devel
mailing list