[pmg-devel] [PATCH pmg-api] api: make SHA-256 fingerprint regex match only hex characters

[Fabian Grünbichler]

so this touches exactly the same code as the other patch you sent half an hour earlier, but no indication here. this should have been a v2 of that patch turning it into a series, but please see my comment there first ;)

> Maximiliano Sandoval <m.sandoval at proxmox.com> hat am 30.10.2024 12:18 CET geschrieben:
> 
>  
> The fingerprints are in hex, plus colons, and should only match A-F.
> 
> Suggested-by: Shannon Sterz <s.sterz at proxmox.com>
> Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
> ---
>  src/PMG/API2/Cluster.pm  | 2 +-
>  src/PMG/CLI/pmgcm.pm     | 2 +-
>  src/PMG/ClusterConfig.pm | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/PMG/API2/Cluster.pm b/src/PMG/API2/Cluster.pm
> index 84dafabb..cc54fb50 100644
> --- a/src/PMG/API2/Cluster.pm
> +++ b/src/PMG/API2/Cluster.pm
> @@ -411,7 +411,7 @@ __PACKAGE__->register_method({
>  	    fingerprint => {
>  		description => "SSL certificate fingerprint.",
>  		type => 'string',
> -		pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$',
> +		pattern => '^(:?[A-F0-9][A-F0-9]:){31}[A-F0-9][A-F0-9]$',
>  	    },
>  	    password => {
>  		description => "Superuser password.",
> diff --git a/src/PMG/CLI/pmgcm.pm b/src/PMG/CLI/pmgcm.pm
> index ecf9cc76..641b4be2 100644
> --- a/src/PMG/CLI/pmgcm.pm
> +++ b/src/PMG/CLI/pmgcm.pm
> @@ -169,7 +169,7 @@ __PACKAGE__->register_method({
>  	    fingerprint => {
>  		description => "SSL certificate fingerprint.",
>  		type => 'string',
> -		pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$',
> +		pattern => '^(:?[A-F0-9][A-F0-9]:){31}[A-F0-9][A-F0-9]$',
>  		optional => 1,
>  	    },
>  	},
> diff --git a/src/PMG/ClusterConfig.pm b/src/PMG/ClusterConfig.pm
> index c52508dc..67b2a512 100644
> --- a/src/PMG/ClusterConfig.pm
> +++ b/src/PMG/ClusterConfig.pm
> @@ -75,7 +75,7 @@ sub properties {
>  	fingerprint => {
>  	    description => "SSL certificate fingerprint.",
>  	    type => 'string',
> -	    pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$',
> +	    pattern => '^(:?[A-F0-9][A-F0-9]:){31}[A-F0-9][A-F0-9]$',
>  	},
>      };
>  }
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pmg-devel mailing list
> pmg-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel