[pmg-devel] [PATCH pmg-api v3 0/3] fix #4211: convert quarantine link mail to template

Christoph Heiss c.heiss at proxmox.com
Tue Oct 8 13:17:50 CEST 2024


Fixes #4211 [0] by converting the currently hardcoded text for the
quarantine link mail to a proper template, enabling users to write their
own versions.

This series also adds the possibility to specify both a HTML and
plaintext template for PMG::Utils::finalize_report() (or just HTML, for
backwards compatibility) - as suggested in [1]. 

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=4211
[1] https://lore.proxmox.com/pmg-devel/20241003172625.49655705@rosa.proxmox.com/

history
=======

v1: https://lore.proxmox.com/pmg-devel/20241001125948.605201-1-c.heiss@proxmox.com/
v2: https://lore.proxmox.com/pmg-devel/20241007103214.1006844-1-c.heiss@proxmox.com/

Notable changes v1 -> v2:
  * add support for plaintext templates in addition to HTML

Notable changes v2 -> v3:
  * add short documentation for email templates

diffstat
========

pmg-api:

Christoph Heiss (2):
  utils: allow specifying plain and/or html for finalize_report()
  fix #4211: convert quarantine link mail to template

 src/Makefile                           |  2 ++
 src/PMG/API2/Quarantine.pm             | 22 ++++++------
 src/PMG/Backup.pm                      |  5 +--
 src/PMG/CLI/pmgqm.pm                   |  5 ++-
 src/PMG/CLI/pmgreport.pm               |  5 ++-
 src/PMG/Utils.pm                       | 49 +++++++++++++++++++++++---
 src/templates/quarantine-link.html.tt  | 13 +++++++
 src/templates/quarantine-link.plain.tt |  5 +++
 8 files changed, 85 insertions(+), 21 deletions(-)
 create mode 100644 src/templates/quarantine-link.html.tt
 create mode 100644 src/templates/quarantine-link.plain.tt

pmg-docs:

Christoph Heiss (1):
  pmgconfig: document support for html and plain-text email templates

 pmgconfig.adoc | 8 ++++++++
 1 file changed, 8 insertions(+)

-- 
2.46.0





More information about the pmg-devel mailing list