[pmg-devel] [PATCH pmg-api 0/3] small improvments to pmgdb dump output

Friedrich Weber f.weber at proxmox.com
Fri Feb 23 11:40:35 CET 2024

All three patches look good to me!

* 1/3 is nice. I've also spent some time analyzing inactive rules, I'd
expect the all-caps active flag to help here.
* 2/3 is nice as well.
* 3/3 sounds potentially useful! Wouldn't pass this flag when generating
the report though, as I'd like to see active and inactive rules there.

Tested-by: Friedrich Weber <f.weber at proxmox.com>

On 22/02/2024 22:06, Stoiko Ivanov wrote:
> inspired by the patch from Dominik [0], I prepared the following patchset,
> which hopefully improves the readability of the pmgdb dump output when
> debugging.
> As these dump-tool output UX questions are quite subjective would be
> grateful for feedback from someone, who had the opportunity to use it for
> debugging.
> [0] https://lists.proxmox.com/pipermail/pmg-devel/2024-February/002690.html
> Stoiko Ivanov (3):
>   pmgdb: highlight active rules
>   pmgdb: drop "found" prefixes for each rule and group
>   pmgdb: add active parameter to dump
>  src/PMG/CLI/pmgdb.pm | 20 ++++++++++++++------
>  1 file changed, 14 insertions(+), 6 deletions(-)

More information about the pmg-devel mailing list