[pmg-devel] applied: [PATCH pmg-gui v3 0/3] implement and combination and inversion of groups and objects

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Feb 22 15:24:48 CET 2024


Am 22/02/2024 um 10:14 schrieb Dominik Csapak:
> since the rest got applied, the new version of the ui part
> 
> note that patch 3 is intended to be an alternative way of handling the
> update of the object list when the mode changes. so if desired can be
> squashed in with patch 2 (needs then the commit message adapted)
> 
> alternatively it can simply be left out
> 
> changes from v2:
> * left out applied patches
> * added padding in the RuleInfo panel for type groupings
> * fixed a bug with deletion
> * incoroporated thomas' suggestions
> 
> changes from v1:
> * rebase on master
> * include new tables in cluster sync + backup
> * incorporate stoikos feedback
> * improved commit messages
> more details in the relevant patches
> 
> changes from rfc:
> * added docs + gui
> * some minor bugfixes
> * fixed the api (forgot to add the info to the GET calls in rfc)
> * changed output for `pmgdb dump` so we get that info in the pmgreport too
> 
> Dominik Csapak (3):
>   rules: use tree panel instead of grouping feature of the grid
>   rules/objects: add mode selector dropdown
>   objects: don't reload on match mode change
> 
>  css/ext6-pmg.css               |  11 ++++
>  js/Makefile                    |   1 +
>  js/ObjectGroup.js              |  72 ++++++++++++++++++++++-
>  js/ObjectGroupConfiguration.js |   7 +++
>  js/RuleInfo.js                 | 102 ++++++++++++++++++++++++++-------
>  js/form/MatchModeSelector.js   |  11 ++++
>  6 files changed, 181 insertions(+), 23 deletions(-)
>  create mode 100644 js/form/MatchModeSelector.js
> 


applied series, with a T-b from Stoiko added, thanks!

for the record: depending on browser and font setup the object edit pane
on the right might lacks some distinction, as the <b> tag might not make
the font use boldface.

But that's a small UX/style hiccup, so either fine to fix afterwards, or
maybe it's really just my local browser+font combination.




More information about the pmg-devel mailing list