[pmg-devel] [PATCH pmg-api v2 04/10] add rule attributes and/invert (for each relevant type)

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Feb 22 07:46:30 CET 2024

Am 21/02/2024 um 13:24 schrieb Dominik Csapak:
> +my $rule_attributes_cmd = <<__EOD;
> +    CREATE TABLE Rule_Attributes (
> +      Rule_ID INTEGER NOT NULL,
> +      Name VARCHAR(20) NOT NULL,
> +      Value BYTEA NULL,

FWIW, with this being such limited to only support a boolean value, the
name could have been a boolean type for invert/and too..

Else it would make more sense to have this either more generic, or make
it a very explicit table (name) like "Rule_Flags".

As of now the name suggests that its generic, but the schema really isn't.
I.e., this feels a bit like the worst of both worlds.

More information about the pmg-devel mailing list