[pmg-devel] [PATCH pmg-gui v2 1/2] rules: use tree panel instead of grouping feature of the grid

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Feb 21 18:42:50 CET 2024


Am 21/02/2024 um 13:24 schrieb Dominik Csapak:
> just in preparation for adding a columnf or the groups

typo (can be amended on applying) s/columnf/column 

> will look similar (though not identical) to before, but this makes
> the groups now real entries in the grid, which means we can have
> content in additional columns

looks OK, as nit: while I do not find it bad that the object-group "heading"
has the same text color as the used objects, some more visual separation might
be good.
For starters, one could maybe check if the cell top/bottom padding should
be increased a bit, as that was a bit higher in the old implementation.

but can be fine tuned after wards, doesn't need any v3 for just this.




More information about the pmg-devel mailing list