[pmg-devel] applied: [PATCH pmg-gui v3] fix #4510: add filter box to many grids

[Thomas Lamprecht]

Am 21/02/2024 um 15:47 schrieb Dominik Csapak:
> namely relay domains, transports, trusted networks, smtp whitelist +
> when/what/who object grids.
> 
> Adds a new 'FilterField', that takes a store and a list of columns to
> filter, and filters on every change.
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> changes from v3:
> * always clear the old filters on the store when the value changes
>   otherwise we only add filter but never remove them
> 
>  js/Makefile            |  1 +
>  js/MyNetworks.js       |  5 ++++
>  js/ObjectGroup.js      | 11 ++++++++
>  js/RelayDomains.js     |  5 ++++
>  js/Transport.js        |  5 ++++
>  js/form/FilterField.js | 57 ++++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 84 insertions(+)
>  create mode 100644 js/form/FilterField.js
> 
>

applied, thanks!

One could argue though that having these for action object might be good
for consistency w.r.t. the other object types.
And even though most setups probably has not _that_ many of those, it has
almost no cost and might be even nice on to find stuff when one has low
count of actions.

Similar for the mail filter rule grid, but no hard feelings for either.