[pmg-devel] [PATCH pmg-api v1] proxy: add support for switching themes

Dominik Csapak d.csapak at proxmox.com
Fri Mar 10 11:14:14 CET 2023


replying here for the whole pmg part of the series

all in all LGTM

besides apart from some minor stuff that
can be done as a follow-up:

* in some parts the indentation is wrong
* the mobile quarantine has still white dialogs
   (seems to be a bug in the framework7 version we use, updating
   to a current version seems non-trivial since we're 3 major
   versions behind, i can do it of course if wanted)
* regarding the quarantine theme toggle:
   why should it not be possible to have a theme toggle when we respect the cookie?
   we can just read the parameter and as a fallback rely on the cookie?
   imho that would be a cleaner solution than inverting the whole mail

if these points are not a problem @Thomas/@Stoiko, consider the pmg part

Reviewed-by: Dominik Csapak <d.csapak at proxmox.com>
Tested-by: Dominik Csapak <d.csapak at proxmox.com>




More information about the pmg-devel mailing list