[pmg-devel] [PATCH widget-toolkit v1 2/6] subscription/summary/backup: stop setting the background color

Stefan Sterz s.sterz at proxmox.com
Wed Mar 8 17:36:56 CET 2023


setting the background color in js code adds that property as a style
attribute to the element. that makes it hard to alter later via css
and makes it hard to dynamically change the color e.g., if we want to
add different themes. the background color for these elements are
white already anyway, so just remove them here.

Signed-off-by: Stefan Sterz <s.sterz at proxmox.com>
---
 src/node/APT.js               | 1 -
 src/window/AddTotp.js         | 1 -
 src/window/DiskSmart.js       | 1 -
 src/window/PackageVersions.js | 1 -
 4 files changed, 4 deletions(-)

diff --git a/src/node/APT.js b/src/node/APT.js
index 2e5a776..739aaf3 100644
--- a/src/node/APT.js
+++ b/src/node/APT.js
@@ -116,7 +116,6 @@ Ext.define('Proxmox.node.APT', {
 	    let view = Ext.createWidget('component', {
 		autoScroll: true,
 		style: {
-		    'background-color': 'white',
 		    'white-space': 'pre',
 		    'font-family': 'monospace',
 		    padding: '5px',
diff --git a/src/window/AddTotp.js b/src/window/AddTotp.js
index bdb4826..080b361 100644
--- a/src/window/AddTotp.js
+++ b/src/window/AddTotp.js
@@ -224,7 +224,6 @@ Ext.define('Proxmox.window.AddTotp', {
 			visible: '{!secretEmpty}',
 		    },
 		    style: {
-			'background-color': 'white',
 			'margin-left': 'auto',
 			'margin-right': 'auto',
 			padding: '5px',
diff --git a/src/window/DiskSmart.js b/src/window/DiskSmart.js
index b538ea1..1cae512 100644
--- a/src/window/DiskSmart.js
+++ b/src/window/DiskSmart.js
@@ -74,7 +74,6 @@ Ext.define('Proxmox.window.DiskSmart', {
 	    autoScroll: true,
 	    padding: 5,
 	    style: {
-		'background-color': 'white',
 		'white-space': 'pre',
 		'font-family': 'monospace',
 	    },
diff --git a/src/window/PackageVersions.js b/src/window/PackageVersions.js
index e79d29f..aaa1372 100644
--- a/src/window/PackageVersions.js
+++ b/src/window/PackageVersions.js
@@ -45,7 +45,6 @@ Ext.define('Proxmox.window.PackageVersions', {
 		html: '{packageList}',
 	    },
 	    style: {
-		'background-color': 'white',
 		'white-space': 'pre',
 		'font-family': 'monospace',
 	    },
-- 
2.30.2





More information about the pmg-devel mailing list