[pmg-devel] [RFC log-tracker] rfc3339: move timezone offset compatibility code to

Dominik Csapak d.csapak at proxmox.com
Fri Aug 4 14:30:31 CEST 2023

On 7/18/23 18:01, Mira Limbeck wrote:
> old time format parsing code
> The compatibility code was added to the new rfc3339 code path temporarily so
> that the old code path would not be changed before the PMG 8 release.
> Now move it to the old time format code to make sure the rfc3339 code path
> works as expected. Since we have all the information we need (year, month,
> day, hours, minutes, seconds, timezone), there's no need for a workaround in
> this code path.
> The change needs to be accompanied by one in pmg-api MailTracker.pmg to
> keep the time displayed in the GUI the same for the old time format, and
> correct for the new rfc3339 format.
> Signed-off-by: Mira Limbeck <m.limbeck at proxmox.com>
> ---
> After talking to Dominik this might be best sent as an RFC for further
> discussions. As such I haven't touched the tests yet.
> This change requires changing all tests, including the new rfc3339 ones.
> Any code that uses the pmg-log-tracker directly may behave differently
> now, since the timestamps it outputs are different than before.

as we already talked off-list, i think we basically have 3 ways forward with this:

* wait for the 9.x release and hope we don't forget to do this
* make the change opt-in and reverse it with 9.x (or maybe remove the old code path then)
   with this, we could change it in the api now, and just leave the cli interface
   compatible by default
* define it as a bug, so we can simply fix it, regardless if the behaviour is now different

i'm either for 2 or 3, but of those either is fine with me (3 is ofc less work)

any input on that @stoiko?

More information about the pmg-devel mailing list