[pmg-devel] applied-series: Re: [PATCH pmg-gui v2 0/2] low-hanging improvments for the quarantine interface

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Oct 28 11:35:42 CEST 2022


On 27/10/2022 21:12, Stoiko Ivanov wrote:
> v1->v2:
> * dropped already applied patches
> * changed the patches, by splitting the refactoring of the spamquarantine
>   in a patch of its own, and changing virus and attachmentquarantine in
>   the second patch (no functional change intended) - big thanks for the
>   suggestion @Thomas!!
> 
> gave me also the chance to see the adaptations of the icon-colors for delivery
> and delete by Thomas in action - I like it!
> 
> original cover-letter for v1:
> A few bugzilla entries ask for features in the quarantine interface that
> seem quite sensible (e.g. #4137), or are already present in the (by far
> more used) spamquarantine, but never made it to the others.
> 
> This patchset contains a single small fix, and a refactoring of the
> quarantine views to use the same controller.
> 
> Would be grateful for feedback
> 
> 
> Stoiko Ivanov (2):
>   quarantine: refactor spamquarantine controller
>   quarantine: use new controller for virus and attachment quarantines
> 
>  js/AttachmentQuarantine.js            | 113 +++++-----
>  js/Makefile                           |   1 +
>  js/SpamQuarantine.js                  | 290 +++++++++-----------------
>  js/VirusQuarantine.js                 |  86 ++------
>  js/controller/QuarantineController.js | 170 +++++++++++++++
>  5 files changed, 335 insertions(+), 325 deletions(-)
>  create mode 100644 js/controller/QuarantineController.js
> 


applied series, many thanks!




More information about the pmg-devel mailing list