[pmg-devel] applied: [PATCH pmg-gui 1/4] fix #4137: display receiver in attachment/virus quarantine

[Thomas Lamprecht]

Am 20/10/2022 um 21:14 schrieb Stoiko Ivanov:
> the attachment and virus quarantines contain all quarantined mail for
> all recipients - so we should display which mail is being
> delivered/deleted - mostly if a mail is sent to multiple addresses
> served by the same PMG.
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
> ---
> * the naming of the sender_renderer (which actually just adds the sender
>   to the subject it actually renders) was adapted for the function name
>   Probably a different choice for both might be clearer
>   (sender_subject_renderer, sender_receiver_subject_renderer)?> 
>  js/AttachmentQuarantine.js |  4 ++--
>  js/Utils.js                | 23 ++++++++++++++++++-----
>  js/VirusQuarantine.js      |  4 ++--
>  3 files changed, 22 insertions(+), 9 deletions(-)
> 
>

applied, thanks! I made a follow up commit cleaning up the code a bit more,
dropping passing along the metaData to the helper fn if it isn't used yet
anyway (if we really get future direct users we can either just wrap it or
re-add it) and transforming the render fns to arrow functions, with render_
in the prefix of the name.

FWIW, I'm not sure that placing the "To" in a new line in the (previously)
"Sender/Subject" column, but maybe rather just add a additional column and
increase the default width of the quarantine grid in attachment/virus Q,
bonus points if it's responsive for smaller (e.g., < 1600px width) windows
/displays, with full hd and bigger the horizontal space is rather unused
anyway. But, that said, it works OK enough as is, and it isn't affecting the
user facing Quarantine, so I don't care to much; just noticed it and wanted
to mention it, maybe someone has a better idea.