[pmg-devel] [PATCH pmg-api 0/2] fix deprecation warning for user blocklist hits
Stoiko Ivanov
s.ivanov at proxmox.com
Mon Nov 28 19:17:27 CET 2022
the 2 patches address quite different issues, both becoming visible when a
mail is blocked/quarantined due to being on the receivers blocklist:
* currently we use the description from SA for 'USER_IN_BLACKLIST', which
includes since a while a deprecation warning (it's been replaced by
USER_IN_BLOCKLIST, and afaict the old version will be dropped with
SpamAssassin 4.0 soon). However PMG's SA rule only shares the name with
the one from upstream SA (in the sense that our source of addresses is
the database and not the SA-config), so we should make sure that the
description is consistent
* We should also rethink/adapt our use of racially charged terms (and try
to be consistent with SpamAssassin upstream in our choices) - I plan on
addressing this once SpamAssassin 4.0 is released (patch 2/2 is only a
small part and only touches the user/admin visible parts for the user
blocklists)
For now the issue is a cosmetic one, and both approaches would address the
spurious DEPRECATED in the spaminfo widget in the GUI (although patch 1/2
moves code around that 2/2 touches)
Stoiko Ivanov (2):
user-bl: use custom description of USER_IN_BLACKLIST consistently
user accesslists: reword logging and hits for SA 4.0
src/PMG/RuleDB/Spam.pm | 10 +++++-----
src/PMG/Utils.pm | 6 ++++++
2 files changed, 11 insertions(+), 5 deletions(-)
--
2.30.2
More information about the pmg-devel
mailing list