[pmg-devel] applied: [PATCH pmg-api 2/5] ruledb: add deprecation warnings for unused actions

[Thomas Lamprecht]

Am 09/11/2022 um 19:27 schrieb Stoiko Ivanov:
> * ReportSpam
> * Attach
> * Counter
> 
> are all still present since (at least) the release of PMG 5.0, but
> were never exposed in the API/GUI.
> 
> All of them in their current form don't seem to fit well nowadays, or
> their functionality was taken over by some other Action:
> * Attach - the functionality is currently present in the Notify action
>   (attach original mail)
> * Counter - without a matching What object simply increasing a counter
>   by one in the database serves no purpose
> * ReportSpam - sending potentially sensitive mail automatically to the
>   public SpamAssassin project does not seem to fit well nowadays
> 
> Instead of dropping them right away - this patch adds logging when
> they are encountered while loading or when they are run, to keep
> backwards-compatibility for users who have very long-running PMG
> instances (not sure if the actions were ever used in the pre git-days
> of PMG)
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
> ---
>  src/PMG/RuleDB.pm            | 14 +++++++++++++-
>  src/PMG/RuleDB/Attach.pm     |  7 +++++++
>  src/PMG/RuleDB/Counter.pm    |  5 +++++
>  src/PMG/RuleDB/ReportSpam.pm |  5 +++++
>  4 files changed, 30 insertions(+), 1 deletion(-)
> 
>

applied, thanks!