[pmg-devel] applied: [PATCH] spam quarantine controller: fix args when calling the parent multiSelect

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Nov 7 13:18:49 CET 2022


arguments needs to be an array, often we call with all of ours, iow.
using `arguments` which itself is an array already.

Both, manual construction and just a passing `arguments` have their
advantage and disadvantage, e.g., if either the inheriting or
bequesting class becomes more specialized, but most of the time using
`arguments` is more future proof.

Fixes: e66c888 ("quarantine: refactor spamquarantine controller")
Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---

avoids an spurious undefined when selecting multiple emails.

 js/SpamQuarantine.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/js/SpamQuarantine.js b/js/SpamQuarantine.js
index 388fc02..7487c8f 100644
--- a/js/SpamQuarantine.js
+++ b/js/SpamQuarantine.js
@@ -51,7 +51,7 @@ Ext.define('PMG.SpamQuarantineController', {
 	spam.setDisabled(true);
 	spam.setPressed(false);
 	me.lookupReference('spaminfo').setVisible(false);
-	me.callParent(selection);
+	me.callParent(arguments);
     },
 
     toggleSpamInfo: function(btn) {
-- 
2.30.2





More information about the pmg-devel mailing list