[pmg-devel] applied: [PATCH pmg-gui 3/5] fix #4238: SpamInfoGrid: enable sorting & add colors for spam score

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Nov 7 10:56:50 CET 2022


Am 04/11/2022 um 16:04 schrieb Dominik Csapak:
> sorting the matching spam rules, e.g. by score, makes it easier to see
> which rules have more weight in determining spam.
> 
> Additionally, color code the scores with colors akin to the rationale
> in commit:
> 365f84c ("quarantines: color code deliver and delete buttons")
> 
> (red for positive spam scores, blue for negative ones)
> 
> and increase the font-weight for large spamscore contributing rules.
> 
> i chose a different blue tone that is more muted than what we use in
> 'info-blue' but is different from both the 'hover' color and the
> 'selected' color
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> while the bug mentions that colors are problematic, there are not enough
> font-weights to properly convey what we want to show here, so i added
> colors with the same rationale we already used for the deliver/delete
> buttons
> 
>  js/SpamInfoGrid.js | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
>

applied, thanks! with some further gradients and a switch to monospace
for the value and spam level names (unrelated to the report, so mentioning
it for completeness sake)




More information about the pmg-devel mailing list