[pmg-devel] [PATCH pmg-api] pmg-daily: avoid short-circuting update of local channels

Stoiko Ivanov s.ivanov at proxmox.com
Tue Jul 12 14:14:28 CEST 2022


by using ||= directly with the actual update call as operand, it does
not get run, if `sa-update` already returned that a restart is needed.

reported in our community forum:
https://forum.proxmox.com/threads/.112112/

Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
---
 src/bin/pmg-daily | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/bin/pmg-daily b/src/bin/pmg-daily
index b06515c..a9bfd1c 100755
--- a/src/bin/pmg-daily
+++ b/src/bin/pmg-daily
@@ -85,7 +85,8 @@ if (system('sa-update') == 0) {
 }
 
 eval {
-    $restart_filter ||= PMG::Utils::update_local_spamassassin_channels(0);
+    my $res ||= PMG::Utils::update_local_spamassassin_channels(0);
+    $restart_filter ||= $res;
 };
 syslog('err', "$@") if $@;
 
-- 
2.30.2





More information about the pmg-devel mailing list