[pmg-devel] [pve-devel] [PATCH proxmox-perl-rs] move apt repositories module to common

[Fabian Ebner]

Am 06.07.22 um 13:13 schrieb Wolfgang Bumiller:
> On Wed, Jul 06, 2022 at 10:54:17AM +0200, Fabian Ebner wrote:
>> while introducing a 'product' parameter to the relevant functions.
>>
>> Suggested-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
>> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
>> ---
>>
>> I did the changes in Proxmox/Lib/Common.pm (and Makefile) manually.
>> Is that the intended way or could I have generated those somehow?
>>
>> Hope I got these right:
>>
>> pve-manager (respectively pmg-api) depends and build-depends on
>> libproxmox-rs-perl and libpve-rs-perl (respectively libpmg-rs-perl).
>> Both are needed, because just upgrading libproxmox-rs-perl doesn't
>> make the new functionality available in the product-specific shared
>> lib.
>>
>> New libpve-rs-perl breaks old pve-manager and new libpmg-rs-perl
>> breaks old pmg-api.
> 
> I mean in theory we could keep the old functions and just have them
> forward to the common module with the corresponding product parameter
> added, for a little while anyway?
> 

Sure, I can send a v2 doing that to postpone the "Breaks".

>> diff --git a/Proxmox/Lib/Common.pm b/Proxmox/Lib/Common.pm
>> index d8a0d57..668986d 100644
>> --- a/Proxmox/Lib/Common.pm
>> +++ b/Proxmox/Lib/Common.pm
>> @@ -6,6 +6,14 @@ Proxmox::Lib::Common - base module for rust bindings common between PVE and PMG
>>  
>>  =head1 SYNOPSIS
>>  
>> +    package Proxmox::RS::APT::Repositories;
>> +
>> +    use base 'Proxmox::Lib::Common';
>> +
>> +    BEGIN { __PACKAGE__->bootstrap(); }
>> +
>> +    1;
>> +
> 
> This is just example documentation, no need to do anything to this file
> at all.
> 

Right :)