[pmg-devel] [PATCH pmg-gui v2] StatTimeSelector: don't show invalid month/day combinations

Dominik Csapak d.csapak at proxmox.com
Fri Jul 1 10:03:24 CEST 2022


by limiting the store of the day selector by the selected month

reported by a user in the forum:
https://forum.proxmox.com/threads/wrong-calendar.111631/

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
changes from v1:
* use js 'Date' to correctly calculate the last day of the month
  including leapyears, etc.

 js/StatTimeSelector.js | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/js/StatTimeSelector.js b/js/StatTimeSelector.js
index f01b058..eae2d91 100644
--- a/js/StatTimeSelector.js
+++ b/js/StatTimeSelector.js
@@ -73,7 +73,25 @@ Ext.define('PMG.StatTimeSelector', {
 	    Ext.GlobalEvents.fireEvent('pmgStatTimeSelectorUpdate', data);
 	},
 
+	updateDays: function() {
+	    let yearsel = this.lookupReference('yearsel');
+	    let monthsel = this.lookupReference('monthsel');
+	    let daysel = this.lookupReference('daysel');
+	    let year = yearsel.getValue();
+	    let month = monthsel.getValue();
+	    // create a date for the next month, but day 0 which wraps to
+	    // the last day of the current month. Our month is already
+	    // 1 greater than what Date expects, so we don't have to add 1
+	    let maxDays = new Date(year, month, 0).getDate();
+	    daysel.getStore().setFilters([{
+		property: 'day',
+		operator: '<=',
+		value: maxDays,
+	    }]);
+	},
+
 	onSelect: function() {
+	    this.updateDays();
 	    this.updateVisibility();
 	},
 
-- 
2.30.2





More information about the pmg-devel mailing list