[pmg-devel] applied-series: Re: [PATCH multiple 0/7] PMG TFA support

Thomas Lamprecht t.lamprecht at proxmox.com
Sun Nov 28 22:17:35 CET 2021

On 26/11/2021 14:55, Wolfgang Bumiller wrote:
> This touches multiple repos as it required some more ground-work on the
> rust side:

applied series, thanks!

Made a few follow ups:

- restricted permissions of tfa add/modify to all but qusers, while the gui wouldn't
  allow it for those, it still could be set up over the API and that'd be confusing at
  best, as it would have any effect if I remember the quarantine user login flow somewhat

- added tfa to the API index of /config and added one for webauthn in tfa, makes pmgsh
  work, among other things

- implemented a webauthn config button, UX could surely get improved a bit but it does
  the job for now.

- added libqrcode js dependency also in pmg-gui, as that's the actual user, albeit pmg-api
  can be fine too, it's not that clear with the split main-api and main-gui packages that
  we only have in PMG.

- docs, well as at least some reference to the biggest newest feature in the docs may be
  expected by some users ;)

More information about the pmg-devel mailing list