[pmg-devel] [PATCH pmg-api v3 0/2] fix #2795 - add DSN support
Stoiko Ivanov
s.ivanov at proxmox.com
Thu Nov 25 20:19:59 CET 2021
huge thanks again to Dominik for his testing and uncovering bugs!
v2->v3:
* adapted the regular expression to also work if not parameters at all are
provided (as happens in after-queue filtering)
* added the DSN-EHLO keyword (else the first postfix instance did send the
notification - whereas we want to send the information on (so that a later
system sends it)
* tried a bit more systematic testing (including changing between before and
after queue filtering)
original cover-letter for v2:
v1->v2:
* incorporated Dominik's feedback - huge thanks!!
* all parameters we don't care about are ignored (as before)
* the options are not transformed into lowercase unconditionally anymore
(they contain mail-addresses, and mail-ids - which are not case-insensitive)
* split up the patch into 2 commits - since the regexes for the MAIL and
RCPT commands is more sensitive than I expected:
** read up on allowed characters in local-parts - tried extending the regex
to parse mailboxes more correctly - failed at that
** decided it's ok to not allow '>' in localparts (we did not do so before)
** did quite a bit more testing thanks to that
Stoiko Ivanov (2):
partially fix #2795: allow for '>' in smtp parameters
fix #2795: add support for DSN
src/PMG/RuleDB/Accept.pm | 2 +-
src/PMG/RuleDB/BCC.pm | 6 +++++-
src/PMG/SMTP.pm | 29 +++++++++++++++++++++++------
src/PMG/Utils.pm | 19 ++++++++++++++++---
src/bin/pmg-smtp-filter | 1 +
5 files changed, 46 insertions(+), 11 deletions(-)
--
2.30.2
More information about the pmg-devel
mailing list