[pmg-devel] [PATCH widget-toolkit 5/7] add ACME account panel

[Thomas Lamprecht]

On 11.03.21 16:16, Dominik Csapak wrote:
> 
> 
> On 3/11/21 4:14 PM, Thomas Lamprecht wrote:
>> On 11.03.21 14:51, Dominik Csapak wrote:
>>> high level question/remark:
>>>
>>> would it not be nicer if we set the acmeUrl
>>> in Proxmox.Utils to e.g., /config/acme
>>> and overwrite that in pve ? (like
>>> we do with task descriptions?)
>>>
>>> this way the caller does not have to concern
>>> itself with the url and we only set it one time per product
>>>
>> I like the idea in general, but the Utils class are quite overused/crowded
>> already, and this is rather not a Util but a config, maybe a Proxmox.Config
>> class could be added and used?
>>
> yeah, or maybe we could have a general 'Proxmox.APIPaths' class that contains the paths for wt relevant stuff? so that we do not have
> to design the api of new products in such a way that all products
> are the same (e.g. /nodes/YYY/ stuff)

IMO that would be a object of Proxmox.Config, avoiding to many top level classes
which are all would fit in the "product specific properties/configs/api-paths"
category.

Just as example, something like

Ext.define('Proxmox.Cfg', {

    APIPaths: {
        host_disk: {
            get: ...,
            put: ....,
        }
    },

    // possible other stuff

});


But yeah, I'd like to avoid repeating what we did in PBS with starting out with
/api2/ as prefix, that feels a bit weird.