[pmg-devel] [PATCH pmg-api/gui/docs v2] small improvments for PBS integration

Stoiko Ivanov s.ivanov at proxmox.com
Mon Mar 1 15:12:17 CET 2021


v2->v1:
* addressed Thomas great feedback!:
** reordered the patches (the prevention of the race for concurrent
   pbs-backup is not before the notification feature)
** concurrent pbs-backups now simply use a backup-tmpdir indexed by
   remote+pid+time instead of locking.
** printing and exiting on error now happen as before (instead of being delayed)
** default is 'never' (instead of the unclear mix of 'error' in the schema
   and 'never' in the code
** not having an admin-email configured is treated as warning.

original cover-letter for v1:
This patchset addresses #3146 and #3154.
Additionally I added patches for small cosmetic cleanups, and a fix
for concurrent pbs-backups (they raced with each other during my tests)

patch 1/4 for pmg-gui depends on an updated pmg-docs-generator for building
(and on an updated pmg-docs for linking to the correct section)

pmg-api:
Stoiko Ivanov (3):
  backup: pbs: prevent race in concurrent backups
  backup: fix #3146 add email notifications
  backup: add notify parameter to 'classic' backup

 src/Makefile                         |  1 +
 src/PMG/API2/Backup.pm               | 23 +++++++++++--
 src/PMG/API2/PBS/Job.pm              | 50 +++++++++++++++++++++-------
 src/PMG/Backup.pm                    | 35 +++++++++++++++++++
 src/PMG/PBSConfig.pm                 |  7 ++++
 src/templates/backup-notification.tt | 19 +++++++++++
 6 files changed, 120 insertions(+), 15 deletions(-)
 create mode 100644 src/templates/backup-notification.tt

pmg-gui:
Stoiko Ivanov (4):
  backup: pbs: add onlineHelp anchors
  backup: fix #3154: make statistic backup optional
  backup: pbs: fix #3154: add statistic setting to remote
  backup: pbs: fix #3146  add notify setting to remote

 js/BackupRestore.js   | 45 ++++++++++++++++++++++++++++---------------
 js/PBSConfig.js       |  1 +
 js/PBSRemoteEdit.js   | 20 +++++++++++++++++++
 js/PBSSnapshotView.js | 19 +++---------------
 4 files changed, 53 insertions(+), 32 deletions(-)

pmg-docs:
Stoiko Ivanov (1):
  backup: shortly document #3146 and #3154

 pmgbackup.adoc | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.20.1





More information about the pmg-devel mailing list