[pmg-devel] applied: [PATCH pmg-api] api: nodeconfig: validate acme config before writing

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Jun 28 15:27:41 CEST 2021


On 16.06.21 20:36, Stoiko Ivanov wrote:
> Currently it is possible to add the same domains as different
> acmedomainX keys to the node config, which prevents the user from
> ordering certificates later.
> 
> This patch adds a call to get_acme_conf, which does the semantic
> validation (and is also used in all other sites, which read the
> config).
> 
> Reported in our community forum:
> https://forum.proxmox.com/threads/lets-encrypt-cert-on-gui-not-working.91014/
> 
> quickly tested in my setup, by successfully adding the same domain
> twice without the patch, and failing to do so with it applied.
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
> ---
>  src/PMG/API2/NodeConfig.pm | 3 +++
>  1 file changed, 3 insertions(+)
> 
>

applied, thanks!




More information about the pmg-devel mailing list