[pmg-devel] [PATCH pmg-api 0/2] remove unused greylist table column and make test_gl more robust
Dominik Csapak
d.csapak at proxmox.com
Wed Jun 16 13:04:14 CEST 2021
looks good, works as advertised.
did not matter if i upgraded a master node first or not
(since we did not rely on the host column any more anyway)
nice :)
i could not reproduce the original problem of the second patch,
but it did not break it, so also ok
Reviewed-By: Dominik Csapak <d.csapak at proxmox.com>
Tested-By: Dominik Csapak <d.csapak at proxmox.com>
On 6/11/21 5:54 PM, Stoiko Ivanov wrote:
> These two patches are the result from some intial trials to build and test
> PMG on debian bullseye
>
> The first drops a deprecated database column, and since I consider changes
> to the database schema somewhat sensitive I'd like another set of eyes
> to look over the changes
>
> the second patch addresses a timing issue in test_greylist.pl, which
> causes the tests to fail, because the policy daemon is not accepting
> connections early enough (at least on my test-container with bullseye)
> One alternative would be to skip the greylist tests here which would
> enables building as non-root user.
>
> Stoiko Ivanov (2):
> greylisting: drop unneeded Host column form cgreylist table
> tests: greylist: retry connecting 3 times
>
> src/PMG/Cluster.pm | 3 +--
> src/PMG/DBTools.pm | 21 +++++++++++++++------
> src/bin/pmgpolicy | 6 ++----
> src/tests/test_greylist.pl | 14 ++++++++++----
> 4 files changed, 28 insertions(+), 16 deletions(-)
>
More information about the pmg-devel
mailing list