[pmg-devel] [PATCH widget-toolkit] sorters: use correct property 'direction' and keep default 'ASC'

Fabian Ebner f.ebner at proxmox.com
Tue Dec 7 12:53:30 CET 2021


Ext.util.Sorter does not have an 'order' property, so 'order: DESC'
didn't have an effect. The default is 'ASC' and it is arguably the
preferred direction for realm anyways.

Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
---

I'll also send a patch for PVE later. PBS doesn't have this mistake
anywhere AFAICS.

 src/panel/AuthView.js     | 2 +-
 src/window/ACMEAccount.js | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/panel/AuthView.js b/src/panel/AuthView.js
index 781e84e..69fe1a5 100644
--- a/src/panel/AuthView.js
+++ b/src/panel/AuthView.js
@@ -39,7 +39,7 @@ Ext.define('Proxmox.panel.AuthView', {
 	model: 'pmx-domains',
 	sorters: {
 	    property: 'realm',
-	    order: 'DESC',
+	    direction: 'ASC',
 	},
     },
 
diff --git a/src/window/ACMEAccount.js b/src/window/ACMEAccount.js
index 05278a8..cf16736 100644
--- a/src/window/ACMEAccount.js
+++ b/src/window/ACMEAccount.js
@@ -45,7 +45,7 @@ Ext.define('Proxmox.window.ACMEAccountCreate', {
 		proxy: { type: 'proxmox' },
 		sorters: {
 		    property: 'name',
-		    order: 'ASC',
+		    direction: 'ASC',
 		},
 	    },
 	    listConfig: {
-- 
2.30.2





More information about the pmg-devel mailing list