[pmg-devel] [PATCH pmg-api 1/2] pbs: api: add statistic parameter to run_backup

[Dietmar Maurer]

> On 11/19/2020 9:40 AM Stoiko Ivanov <s.ivanov at proxmox.com> wrote:
> 
>  
> On Wed, 18 Nov 2020 19:34:23 +0100 (CET)
> Dietmar Maurer <dietmar at proxmox.com> wrote:
> 
> > why does this default => 1 ?
> mostly to mirror the way it is with the local-backup (to tar.gz):
> https://git.proxmox.com/?p=pmg-api.git;a=blob;f=src/PMG/API2/Backup.pm;h=4ea28d13e28f23956ec7e0ff64e77ea04a333a53;hb=HEAD#l122
> 
> I also think that we should rather backup more than less in the default
> case - I personally be more disappointed to lose my year long statistics
> in case of disaster than about ~100 M (estimated based on our
> productive instance) more space on my backupstorage.
> You do have a point regarding size (backup without statistics is usually <
> 500k vs 100M) though - so making this comfortably configurable would be a
> nice enhancement! 
> 
> Making this actually user-selectable (apart from a direct API-call or
> using `pmgbackup` manually) would need exposing this in the GUI (and
> somehow getting it in the systemd-service units).
> 
> Would recording this in bugzilla work for you?

sure