[pmg-devel] applied-series: [PATCH pmg-api/pmg-log-tracker v2] add dedicated before queue status

Thomas Lamprecht t.lamprecht at proxmox.com
Wed May 13 13:48:46 CEST 2020


On 4/30/20 5:01 PM, Stoiko Ivanov wrote:
> chagnes v1->v2:
> * added short comment based on Mira's review (thanks!)
> * added R-b, T-b tags from the review mails.
> 
> while trying to add a new test-case (when pmg-smtp-filter yields different
> results for differnt recipients in the before-queue case) I noticed a small
> glitch - however this has been present all the way back to the first version
> with before-queue filtering support - and will be fixed independently - see
> #2713
> 
> cover-letter from v1:
> This patchset aims to provide the same output of the API for the status
> of before-queue and after-queue filtered mails.
> 
> Since the current output of pmg-log-tracker does not provide enough information
> in the before-queue case (apart from successfully delivered downstream mails),
> I added 3 new status-values for before-queue filtered mails, which are then
> translated in the pmg-api to the same values as in the after-queue case.
> 
> This is my first patch to Rust code and is mostly due to copy is my hobby, so
> an experienced look would be very much appreciated!
> 
> pmg-api:
> Stoiko Ivanov (1):
>   MailTracker: handle before queue status
> 
>  src/PMG/API2/MailTracker.pm | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)
> 
> pmg-log-tracker:
> Stoiko Ivanov (2):
>   Introduce before queue dstatus
>   add test for before queue dstatus
> 
>  src/main.rs                                   | 21 +++++++++++-
>  tests/test_input_mixed                        | 32 +++++++++++++++++++
>  tests/test_output_before_queue                |  8 ++---
>  tests/test_output_before_queue_host           |  8 ++---
>  .../test_output_before_queue_mixed_downstream | 21 ++++++++++++
>  tests/test_output_before_queue_qid            |  8 ++---
>  tests/tests_before_queue.rs                   | 21 ++++++++++++
>  7 files changed, 106 insertions(+), 13 deletions(-)
>  create mode 100644 tests/test_output_before_queue_mixed_downstream
> 

applied this series, followup for style issue with the api patch and log-tracker
will only bumped after I got Fabians toolchain update :)



More information about the pmg-devel mailing list