[pmg-devel] [PATCH pmg-api 0/3] small improvements to pmgqm

Dominik Csapak d.csapak at proxmox.com
Thu Mar 19 15:38:24 CET 2020


series LGTM

Reviewed-By: Dominik Csapak <d.csapak at proxmox.com>

On 3/19/20 2:02 PM, Stoiko Ivanov wrote:
> This small series fixes a few cosmetic glitches in pmgqm (pmg quarantine
> manager):
> 
> * small glitch in one die statement was fixed
> * running the 'send' and 'status' subcommands on non-master nodes warn+return
>    now instead of dying with an exit-code >0
> * a reordering of the commands in 'pmgspamreport.service' should make it more
>    robust and prevent the disk from filling up (alternative solution as comment
>    on the individual patch)
> 
> The series is due to a user reporting that one of their nodes ran out of
> diskspace in the forum:
> https://forum.proxmox.com/threads/disk-usage-and-maintenance.64960/
> 
> Actually applying patch 2/3 also fixes that particular issue - so patch
> 3/3 can be considered optional.
> 
> The series also gave me the opportunity to get more familiar with faketime(1)
> (especially the NO_FAKE_STAT variable ;)
> 
> Stoiko Ivanov (3):
>    fix die statement in CLI/pmgqm
>    pmgqm: warn if not running on master
>    pmgspamreport: purge before sending reports
> 
>   debian/pmgspamreport.service | 2 +-
>   src/PMG/CLI/pmgqm.pm         | 6 ++++--
>   2 files changed, 5 insertions(+), 3 deletions(-)
> 




More information about the pmg-devel mailing list