[pmg-devel] [PATCH pmg-gui v2] fix #2632: use alternative api call for user black/whitelist

Dominik Csapak d.csapak at proxmox.com
Wed Mar 11 12:03:34 CET 2020


which expects the entry as parameter instead of part of the path
this allows all special characters to be included in the entry

in the url, some characters were problematic (e.g. '/') and not properly
handled by the api in the backend

we use Ext.applyIf (which copies the non-existant entries to params) here
instead of getting the ExtraParams from the proxy and setting '.address'
(that would modify the ExtraParams of the proxy and send unwanted
parameters to subsequent api calls like the list-loading)

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
changes from v1:
* used applyIf instead of apply
* seperated the assignments

 js/UserBlackWhiteList.js | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/js/UserBlackWhiteList.js b/js/UserBlackWhiteList.js
index c103d54..dd681a0 100644
--- a/js/UserBlackWhiteList.js
+++ b/js/UserBlackWhiteList.js
@@ -73,11 +73,10 @@ Ext.define('PMG.UserBlackWhiteList', {
 
 	    var url = '/quarantine/' + me.listname + '/';
 
-	    url += records.map(function(rec) {
-		return encodeURIComponent(rec.getId());
-	    }).join(',');
-
-	    var params = me.getStore().getProxy().getExtraParams() || {};
+	    let params = {
+		address: records.map((rec) => rec.getId()).join(','),
+	    };
+	    Ext.applyIf(params, me.getStore().getProxy().getExtraParams());
 
 	    Proxmox.Utils.API2Request({
 		url: url + '?' + Ext.Object.toQueryString(params),
-- 
2.20.1




More information about the pmg-devel mailing list