[pmg-devel] [PATCH pmg-gui 1/1] fix #2632: use alternative api call for user black/whitelist

[Thomas Lamprecht]

On 3/11/20 11:52 AM, Dominik Csapak wrote:
>> Hmm, OK but as expressed it was slightly confusing to me.. if (theoretically) extraParams
>> has an "address" member we would also override ours here (apply vs. applyIf)
>>
>> maybe we could go for
>>
>> let params = me.getStore().getProxy().getExtraParams() || {};
>> params.address = records.map((rec) => rec.getId()).join(',');
> 
> that is exactly what does not work because
> params is now a reference to the Extraparams of the proxy (which
> we do not want to modify)
> 

oh, I could've read your commit message - sorry ^^

>>
>> or
>>
>> let params = {
>>      address: records.map((rec) => rec.getId()).join(','),
>> };
>> Ext.applyIf(params, me.getStore().getProxy().getExtraParams());
> 
> yeah this is better