[pmg-devel] [PATCH spamassassin 0/9] don't ship config files and refactor buildsystem

Stoiko Ivanov s.ivanov at proxmox.com
Mon Jan 20 19:37:26 CET 2020

This patchset started out with fixing 2 issues noticed during the last
version updated of SpamAssasin (the first 2 patches):
* We ship the complete config-files in '/etc/mail/spamassassin' despite
  overwriting some of them with the templating system - this caused
  spurious questions about changed config-files (the users did not actively
  change the files)
* building spamassassin resulted in not reproducible test-failures -
  mitigated by running the tests during build time (instead of during the
  binary target)

The rest of the patches resulted from my try to refactor the building of the
package (by relying on debhelper defaults):
* the source format got changed to 3.0 (quilt)
* the rules file was shortened and contains only the necessary overrides
  (to create the package without differences to before)
* a dedicated 'dsc' target was introduced
* linitan warnings for the source-package were fixed

The resulting package was compared against one built from master with:
` diffoscope --exclude './usr/bin/spamc' old.deb new.deb`

Testing was done by installing the new version on top of a fresh
PMG 6.0 container (to check the SA version change)

Stoiko Ivanov (9):
  do not ship config-files rendered from templates
  buildsys: call 'make test' in build target
  buildsys: use debhelper for building
  buildsys: raise debian/compat to 12
  buildsys: add explicit dsc target
  buildsys: fix lintian warnings
  d/control: drop depends on zlib
  buildsys: remove unused patches.
  d/control: bump Standards-Version to 4.3.0

 Makefile                                   |  32 +++++--
 debian/compat                              |   2 +-
 debian/control                             |   7 +-
 debian/install                             |   1 +
 debian/patches/bug_760277_net_dns_URIDNSBL |  34 -------
 debian/patches/bug_821385_dnsresolver      |  18 ----
 debian/patches/bug_835494_perl_INC         |  13 ---
 debian/patches/dkim_subdomains             |  64 -------------
 debian/patches/fix-uninitialized-concat    |  25 -----
 debian/rules                               | 101 ++++-----------------
 debian/source/format                       |   1 +
 debian/source/include-binaries             |   1 +
 12 files changed, 45 insertions(+), 254 deletions(-)
 create mode 100644 debian/install
 delete mode 100644 debian/patches/bug_760277_net_dns_URIDNSBL
 delete mode 100644 debian/patches/bug_821385_dnsresolver
 delete mode 100644 debian/patches/bug_835494_perl_INC
 delete mode 100644 debian/patches/dkim_subdomains
 delete mode 100644 debian/patches/fix-uninitialized-concat
 create mode 100644 debian/source/format
 create mode 100644 debian/source/include-binaries


More information about the pmg-devel mailing list