[pmg-devel] [PATCH pmg-api/pmg-log-tracker] add dedicated before queue status

Mira Limbeck m.limbeck at proxmox.com
Thu Apr 30 11:00:31 CEST 2020


Looks good to me. One nit on patch 1.

Otherwise consider all 3 patches:

Reviewed-By: Mira Limbeck <m.limbeck at proxmox.com>

Tested-By: Mira Limbeck <m.limbeck at proxmox.com>

On 4/28/20 8:51 PM, Stoiko Ivanov wrote:
> This patchset aims to provide the same output of the API for the status
> of before-queue and after-queue filtered mails.
>
> Since the current output of pmg-log-tracker does not provide enough information
> in the before-queue case (apart from successfully delivered downstream mails),
> I added 3 new status-values for before-queue filtered mails, which are then
> translated in the pmg-api to the same values as in the after-queue case.
>
> This is my first patch to Rust code and is mostly due to copy is my hobby, so
> an experienced look would be very much appreciated!
>
> pmg-log-tracker:
> Stoiko Ivanov (2):
>    Introduce before queue dstatus
>    add test for before queue dstatus
>
>   src/main.rs                                   | 19 ++++++++++-
>   tests/test_input_mixed                        | 32 +++++++++++++++++++
>   tests/test_output_before_queue                |  8 ++---
>   tests/test_output_before_queue_host           |  8 ++---
>   .../test_output_before_queue_mixed_downstream | 21 ++++++++++++
>   tests/test_output_before_queue_qid            |  8 ++---
>   tests/tests_before_queue.rs                   | 21 ++++++++++++
>   7 files changed, 104 insertions(+), 13 deletions(-)
>   create mode 100644 tests/test_output_before_queue_mixed_downstream
>
> pmg-api:
> Stoiko Ivanov (1):
>    MailTracker: handle before queue status
>
>   src/PMG/API2/MailTracker.pm | 18 ++++++++++++++----
>   1 file changed, 14 insertions(+), 4 deletions(-)
>



More information about the pmg-devel mailing list