[pmg-devel] [PATCH pmg-api/gui/docs v2] enhance greylist (configurable mask + ipv6 support)

Dominik Csapak d.csapak at proxmox.com
Mon Apr 20 16:28:24 CEST 2020


Series looks mostly good,
some nits on the relevant patches

seems to work as expected, but i'd have to
test tomorrow a little more in depth

one thing that is non-obvious but expected,
as soon as one node is updated, the others
(older version) cannot sync the greylist entries anymore...

we should mention in our upgrade documentation that
most of the time it is required to update the slaves first?
altough in this case it does not make a difference
(since all sync from all)

another thing is that AFAIU, that if the admin changes the netmask
length, all entries in the greylistdb are not used anymore,
regardless in which direction (so from e.g. /20 to /24 and vice-versa)

as an admin, i'd probably expect that in such case it would still match
(it cannot with this patch, since we lose information on save;
well it could work out when going from a smaller to bigger subnet?)
not a real problem since it should not happen that often, but probably 
docs-worthy ;)



More information about the pmg-devel mailing list