[pmg-devel] [PATCH pmg-gui 1/3] fix #2680: make Quarantine E-Mail list searchable

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Apr 16 11:10:53 CEST 2020

On 4/16/20 11:06 AM, Dominik Csapak wrote:
>> So from the offlist discussion, I wasn't mistaken that I did something to open
>> the picker on field focus:
>> https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=851c032d69ad5ae23725dd1add9e4084ebc12650
>> You ported it over to widget toolkit, so thegit blame is biased ;P
> yeah, i did not read the commit message ^^

the comments formatting and "good" (/s) grammar style already smelled
like mine ;P

>> https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=commitdiff;h=39d9914990920758306edd2c9804b034eaa74e41
>> We could either create a child class of combobox or override it's initComponent? >
> i have to create a childclass ("proxmoxCombobox" ?) because if you
> override the initComponent on a static declaration, callParent does not ivoke initComponent of the combobox, but one level above ^^

you can just manually call the correct initComponent "parent" explicit (with full
class path with correct me scope), I've done that somewhere too - that could maybe

> i'll send a v2 of that patch (2,3 are really separate but touch the same file, should i send them again?)

no wait, I'll probably apply them as is 

More information about the pmg-devel mailing list