[pmg-devel] [PATCH pmg-api/pmg-gui] fix #2529: add archive filename what object
Stoiko Ivanov
s.ivanov at proxmox.com
Wed Apr 15 17:08:53 CEST 2020
Thanks for the quick and lean implementation!
LGTM codewise - one suggestion for the second patch for the api (replied to
the patch)
I did give it a quick spin on my testsetup - works as advertised.
with or without the suggestion:
Reviewed-By: Stoiko Ivanov <s.ivanov at proxmox.com>
Tested-By: Stoiko Ivanov <s.ivanov at proxmox.com>
On Tue, 14 Apr 2020 14:54:38 +0200
Dominik Csapak <d.csapak at proxmox.com> wrote:
> modeled after the archive filter (for mime types), matches filenames in
> archives (and outside)
>
> pmg-api:
>
> Dominik Csapak (2):
> collect filenames on unpack
> add new What Object 'Match Archive Filename'
>
> src/Makefile | 1 +
> src/PMG/API2/What.pm | 2 +
> src/PMG/RuleCache.pm | 4 +-
> src/PMG/RuleDB.pm | 4 +
> src/PMG/RuleDB/MatchArchiveFilename.pm | 115 +++++++++++++++++++++++++
> src/PMG/Unpack.pm | 6 +-
> src/bin/pmg-smtp-filter | 1 +
> 7 files changed, 131 insertions(+), 2 deletions(-)
> create mode 100644 src/PMG/RuleDB/MatchArchiveFilename.pm
>
> pmg-gui:
>
> Dominik Csapak (1):
> add 'Match Archive Filename' to list of what objects
>
> js/ObjectGroupConfiguration.js | 2 +-
> js/Utils.js | 25 +++++++++++++++++++++++++
> 2 files changed, 26 insertions(+), 1 deletion(-)
>
More information about the pmg-devel
mailing list