[pmg-devel] [PATCH pmg-api/pmg-gui] cosmetic improvments to quarantine reports

Dominik Csapak d.csapak at proxmox.com
Tue Apr 7 12:13:36 CEST 2020


LGTM

Reviewed-By: Dominik Csapak <d.csapak at proxmox.com>
Tested-By: Dominik Csapak <d.csapak at proxmox.com>

On 4/2/20 7:51 PM, Stoiko Ivanov wrote:
> While working on a reverse-proxy setup, which exposes the quarantine interface
> I noticed again, that the links in the report always append the port, even
> if it's the default one for the scheme.
> 
> While changing the code to not include the port in the default case I also
> removed a variable, which was not used anywhere else (1/2 in pmg-api)
> 
> The patch to pmg-gui makes the port configurable via GUI, since it seems a
> common use-case.
> 
> Tested by setting various combinations of protocol and port in pmg.conf and
> sending a spamreport in my testsetup.
> 
> pmg-api:
> Stoiko Ivanov (2):
>    pmgqm: remove unused variable
>    Skip writing default ports in spamreports
> 
>   src/PMG/CLI/pmgqm.pm | 13 +++++++++----
>   1 file changed, 9 insertions(+), 4 deletions(-)
> 
> pmg-gui:
> Stoiko Ivanov (1):
>    Add port to SpamQuarantineOptions
> 
>   js/SpamQuarantineOptions.js | 2 ++
>   1 file changed, 2 insertions(+)
> 



More information about the pmg-devel mailing list